On Tuesday 08 June 2010 17:17:42 you wrote: > On Fri, 2010-06-04 at 17:31 +0100, Sascha Peilicke wrote: > > > > As far as I know, Qt D-Bus needs annotations to define the > > > > corresponding local types. How do you intend to add them to the > > > > installed files? > > > > > > Uhm, currently I added those locally. I agree, we'd have to parse those > > > XML files and add corresponding annotations. Maybe someone already > > > wrote a tool for that. As an alternative, we could simply add those > > > annotations to the provided files as they shouldn't hurt. > > > > Seems like dbus-binding-tool doesn't allow annotations in XML files > > altough they're in the DTD. So I'm attaching my (resulting) files for > > reference as well as the patch for the original files (won't work > > though). > > I've fixed this by filtering out these elements in the files that > dbus-binding-tool is invoked on. See the new qt-binding branch in the > SyncEvolution repo. Great, thanks.
> These are the annotations as they were made by Carl Wong, not the ones > that you added - sorry for the duplication of effort. Please let's use > the ones from Carl because there is more code (not public yet) which > depends on them. He also added some annotations which were not possible > out-of-the-box without defining some custom types for them. Sounds good, I'll have a look at it. > On the other hand, some new methods and signals were not annotated yet > by Carl. Further patches for those are welcome. > > > Also I had to change the parameter name 'template' of the GetConfig() and > > GetConfigs() methods of the session and server definition as this is a > > keyword in C++ and won't compile. I simply changed it to 'templates' > > (patch attached). > > That's also in Carl's patch, except that he renamed it to "tmplate". This maybe nit-picky but 'templates' maybe more appropriate, as the intend is to return a list of strings. -- Sascha Peilicke http://saschpe.wordpress.com
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ SyncEvolution mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution
