----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/30/#review81 -----------------------------------------------------------
Unfortunately, I cannot view the patch using this site. It complaints about the use of control characters. I'm not sure whether its about the i18n characters in your name. So, I cannot comment "in place." In general the patch is good enough, but I have two issues. I prefer a bit more whitespace. In particular a space after commas and before and after infix operations. I would like that to become part of the Synfig styleguide. Also, have you investigated why Gtk uses the comma instead of the dot in the combo box widget? Does it have to do with i18n/l10n? - Gerco On 2009-06-20 05:27:11.383735, Carlos López González wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://patches.synfig.org/r/30/ > ----------------------------------------------------------- > > (Updated 2009-06-20 05:27:11.383735) > > > Review request for Synfig. > > > Summary > ------- > > Include predefined and preferred FPS in the Setup Dialog. Also modify the > behavior of the spin buttons for preferred x and y canvas size for new > documents to be sensitive only if Custom size is selected. > > > Diffs > ----- > > synfig-studio/trunk/src/gtkmm/app.h 507bc75 > synfig-studio/trunk/src/gtkmm/app.cpp 3099c44 > synfig-studio/trunk/src/gtkmm/dialog_setup.h e0d8fcd > synfig-studio/trunk/src/gtkmm/dialog_setup.cpp 9f849b0 > > Diff: http://patches.synfig.org/r/30/diff > > > Testing > ------- > > Compile, runs and save and load preferences fine. Preferences are properly > reflected on new created documents. > > > Screenshots > ----------- > > Modified SetUp Dialog - Document tab > http://patches.synfig.org/r/30/s/5/ > > > Thanks, > > Carlos > > ------------------------------------------------------------------------------ _______________________________________________ Synfig-devl mailing list Synfig-devl@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synfig-devl
