> On 2009-06-24 01:02:18.740623, Gerco Ballintijn wrote: > > Unfortunately, I cannot view the patch using this site. It complaints about > > the use of control characters. I'm not sure whether its about the i18n > > characters in your name. So, I cannot comment "in place." In general the > > patch is good enough, but I have two issues. I prefer a bit more > > whitespace. In particular a space after commas and before and after infix > > operations. I would like that to become part of the Synfig styleguide. > > Also, have you investigated why Gtk uses the comma instead of the dot in > > the combo box widget? Does it have to do with i18n/l10n? > > Carlos López González wrote: > It is not a good new to hear that you cannot properly use this patch > tracker to comment in place. I have not idea what's the reason. If it is > needed I'll remove all my accented letters from the diffs and from any > information I have in my account. I hope it would help. > Regarding the more whitespace (I guess you are talking on the code style) > it is not a problem to me. I prefer it too. Also a white space after a comma > and infix operations is a good idea. I'll try to fix it in this patch and > keep in mind in the future. > Regarding to the dot in the combo box widgets it is due to when I use > atof with a "24.976" string I obtain 24 and when I do it with a "24,976" > string I obtain the correct value. > As you can check there are lots of dot comma inconsistence in the > .synfig/setup file. Many values are dots and many are commas. I have for > example several different formats for the saved settings of the wacom device. > Maybe i can just to it reverse: create the strings to show based on a > formatted printf operation using double variables. Let's see what I obtain. > Do you think I can commit it, anyway?
I have found that the format shown in the widgets depends on what's the local preferences you use. I have the comma for decimal preference (I hate it but it is Spanish standard). When I run synfigstudio I see comma separator for the brush size for example. When I run LANG=C synfigstudio I see dot decimal separator. So I've modified the patch to insert the strings according the current decimal separator used when the program runs. Doing that it will be consistent always and don't produce a bug when you run the program in other language than Spanish. Thanks for pointing it out. I'll attach a new patch. I keep the same base for the branch. - Carlos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/30/#review81 ----------------------------------------------------------- On 2009-06-20 05:27:11.383735, Carlos López González wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://patches.synfig.org/r/30/ > ----------------------------------------------------------- > > (Updated 2009-06-20 05:27:11.383735) > > > Review request for Synfig. > > > Summary > ------- > > Include predefined and preferred FPS in the Setup Dialog. Also modify the > behavior of the spin buttons for preferred x and y canvas size for new > documents to be sensitive only if Custom size is selected. > > > Diffs > ----- > > synfig-studio/trunk/src/gtkmm/app.h 507bc75 > synfig-studio/trunk/src/gtkmm/app.cpp 3099c44 > synfig-studio/trunk/src/gtkmm/dialog_setup.h e0d8fcd > synfig-studio/trunk/src/gtkmm/dialog_setup.cpp 9f849b0 > > Diff: http://patches.synfig.org/r/30/diff > > > Testing > ------- > > Compile, runs and save and load preferences fine. Preferences are properly > reflected on new created documents. > > > Screenshots > ----------- > > Modified SetUp Dialog - Document tab > http://patches.synfig.org/r/30/s/5/ > > > Thanks, > > Carlos > > ------------------------------------------------------------------------------ _______________________________________________ Synfig-devl mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/synfig-devl
