On Wed, Mar 14, 2012 at 4:29 PM, Denis Washington <den...@online.de> wrote:
> Why commenting out? Aren't version control systems there exactly so that you
> don't need to keep such cruft in the current code? I am really wondering
> about the huge amount of commented-out lines in the codebase.

Many of the comments are cruft code, and I agree that those should go.
But others are full features! The classes and methods are all there,
but the code is incomplete in some way. For example, to do the GUI for
guides I uncommented a couple sections of code, and then iterated
until I fixed most of the bugs.

It would definitely be a good idea to eliminate all commented-out
code. At the scale of large code blocks and major features, however, I
prefer to fix stale code instead of implementing something from
scratch. (Much of it was written by Synfig's original authors and
interfaces well with the software). Maybe that's just me.

Actually going through the comments and analyzing them takes a lot of
effort. I tried doing that in synfig-studio but eventually lost
momentum. Perhaps it's worth it to just delete all of the stale code
in one pass and start fresh.

Just my thoughts
~Nikita

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Synfig-devl mailing list
Synfig-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synfig-devl

Reply via email to