On Sun, 06.03.11 19:17, Andrey Borzenkov (arvidj...@gmail.com) wrote:
> The patch adds framework for processing Set requests on properties
> and as first consumers allows setting of LogTarget and LogLevel on
> interface org.freedesktop.systemd1.Manager of org.freedesktop.systemd1.
>
> The code should be generic enough to allow processing of any
> property on other objects and interfaces as well.
>
Looks really good! Thanks a lot for the work. This has been on the todo
list for a while.
Merged, with some minimal changes.
Next time, please do not use tabs!
> +static int bus_manager_set_log_target(Manager *m, DBusMessageIter *i, const
> char *property) {
> + const char *t;
> +
> + assert(m);
> + assert(i);
> + assert(property);
> +!
> + t = log_target_to_string(log_get_target());
This is not necessary, is it? Dropped this now while merging.
Thanks a lot!
Lennart
--
Lennart Poettering - Red Hat, Inc.
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
