On Thu, Feb 20, 2014 at 01:21:01AM +0200, Uoti Urpala wrote: > On Wed, 2014-02-19 at 17:53 +0100, Lennart Poettering wrote: > > Zbigniew suggest we should drop -Wdeclaration-after-statement. I am not > > convinced that that would be a good idea since generally declarations > > after statements are an abomination, and we should avoid them, and it is > > nice if gcc warns about that. > > Even if there can be reasonable style disagreements about exactly where > to use mixed declarations, at least some uses of them are certainly > beneficial. It's only a matter of getting used to reading them if you've > only read old-style code before. I'm sure that if C had had mixed > declarations from the beginning, nobody would come up with a coding > style which declared that particular feature to be harmful. > > Given systemd's approach to features, I think it's pretty ironic if its > coding style has a "you can't expect me to get used to new features" > attitude to something that's been used for more than a decade. For a language with a garbage collection mechanism, it's easy to write declarations and forget about them... but for C the human is the one who will find them and do the job...
Even if systemd uses GCC __attribute__ ((cleanup)) (this is a new feature) IMHO we still need that flag. -- Djalal Harouni http://opendz.org _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel