On Tue, Mar 10, 2015 at 11:49:05AM +0100, Lennart Poettering wrote: > On Tue, 10.03.15 08:21, Martin Pitt (martin.p...@ubuntu.com) wrote: > > > > Please, be more careful with complex code like this, this needs more > > > rounds of review before something like this can be merged... > > > > Okay. It went through 4 rounds of review on the ML and several folks > > commented, there were no more outstanding/unaddressed review comments, > > and it seemed to me that we had consensus on IRC to land this now. > > Procedurally, what should I/we do next time before landing such large > > patches? Wait for an explicit ack on the ML from you? > > Well, if it's complex code like this, get Zbigniew or Kay or Tom or so > to say it's OK... I acked the patches, and actually asked Martin to push them. I overlooked the issues — sorry.
Zbyszek _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
