Thanks for your replies! Regarding the question of why I am proposing to fix only pubs in this run. I think it would be good to try this script with a reduced scope of nodes first before raising a more global conversation. I imagine changesets will be easy to retrieve and un-do.
Worth mentioning that, for the majority of the nodes affected, the websites are not incorrect per-se, but they are not URLs because they miss a scheme. This will cause problems to consumers depending on how they use the field (I first noticed this issue when passing the :website tag to a third party library which complained about this) I ran the script on a local database and I have some numbers: For a total of 159 :amenity=pub nodes with missing scheme on their :website - 41 (~26%) can be updated with https as a scheme (safer for the end-user) - 92 (~58%) don't work on https but http can be added as a scheme - 26 (~16%) seem to be offline, not accessible neither on http or https (maybe they can be automatically tagged for fixing? thoughts?) How do I proceed from here? I have a small subset of nodes to test the proposal with, I have tried the script locally with good results and I believe the proposal makes the dataset better for consumers and safer for end-users by adding an https URL to websites that support it -- Rodrigo Díez Villamuera w: http://rodrigodiez.io t: @rodrigodiez_pro p: 00 44 7513 638225 On Sun, 27 Sep 2020 at 19:38, Andrew Hain <andrewhain...@hotmail.co.uk> wrote: > Keep Right flags web links that have gone offline. > > -- > Andrew > ------------------------------ > *From:* Philip Barnes <p...@trigpoint.me.uk> > *Sent:* 27 September 2020 18:49 > *To:* talk-gb@openstreetmap.org <talk-gb@openstreetmap.org> > *Subject:* Re: [Talk-GB] Hello world and automated change proposal: Add > missing URL scheme on UK's Pubs websites > > On Sun, 2020-09-27 at 16:28 +0100, Rodrigo Díez Villamuera wrote: > > Hi all, > > First of all, I would like to introduce myself on this email list and to > thank you all for your contributions to OSM. Great work! > > After some time using OSM as a user, I decided to make my first step as a > contributor, hence this email and the proposal inside. > > Please bear in mind that this is my first attempt to contribute with a > proposal and, although I have done my best reading the community > conventions and best practices, I am sure I have made some mistakes on the > way. Be merciful! :P > > To the point now. > > I am importing a subset of nodes from UK (those tagged with amenity:pub) > for a pet project. > > When analysing the data I realised that some of these nodes contain a > website: tag that does not contain an appropriate URL schema (http/https). > > Ie: www.mypub.com rather than http://www.mypub.com or > https://www.mypub.com > > This goes in contradiction with the Wiki documentation for website. > <https://wiki.openstreetmap.org/wiki/Key:website> > > I created a proposal for a one-off, scoped, automated edit for these nodes > to find the appropiate scheme for the existing URL and retag the nodes. > > I added the proposal to the Automated edits log. You can read it here > <https://wiki.openstreetmap.org/wiki/Automated_edits/rodrigodiez/Add_missing_URL_scheme_to_pub_websites_in_UK> > . > > Just wanted to share the proposal with the UK community, gather your > feedback, comments and advises on how to proceed from here > > One issue I can think of with pubs and websites is that they need checking > to ensure they are still current. > > The defacto method most pubs use to communicate with customers is facebook. > > A more general fix of urls missing http(s)://, why only pubs?. is > probably a maproulette quest. > > Phil (trigpoint) > > _______________________________________________ > Talk-GB mailing list > Talk-GB@openstreetmap.org > https://lists.openstreetmap.org/listinfo/talk-gb >
_______________________________________________ Talk-GB mailing list Talk-GB@openstreetmap.org https://lists.openstreetmap.org/listinfo/talk-gb