On Fri, 22 Aug 2008, Frank Niessink wrote: > 2008/8/22 Jerome Laheurte <[EMAIL PROTECTED]>:
>> Actually, the copy stuff works well for 'real' composite objects, when >> children are actually 'part' of the parent in a 1:n relationship, >> which is not the case with categories. For notes belonging to a task, >> it doesn't cause any problem. Though the fact that the __id is changed >> bugs me (it will cause problems with the synchronization framework, >> for instance). > > The id should *not* be changed when getting or setting the state, but > the id *should* be changed when creating a copy. If I mixed that up > than that's a bug. Agreed. >> * The bug is fixed >> * We can provide a 'local' undo/redo mechanism in the editor dialog >> * We can add functionnality (for instance, edition of categories from >> within the task/note editor) and it will just work (nested dialogs >> scenario described earlier) >> * We can factorize some code by using, for instance, an actual >> CategoryViewer in the task/note/... editor. > > Yes, this does sound attractive. However, please give me a couple of > hours to cleanly separate copy/getstate. The trunk has two failing > unittests related to that, and I'd like to fix that first. I'll let > you know when that's done. I didn't plan on doing anything today anyway :) But I'll have plenty of time this week-end, seeing how bad the weather is here in Paris, and my friends being on holiday. Just tell me when you're finished and I'll start hacking. Cheers Jérôme
