Hi Ning,
>
> Thanks for the patch, we will go through some validation before
> upstreaming your patch...
>
thanks. Note that if you apply the patch, you might as well remove
skip_filename() entirely, as I did in the patch attached here.
Regards
Martin
# HG changeset patch
# User Martin Wilck <martin.wi...@ts.fujitsu.com>
# Date 1456235571 -3600
# Tue Feb 23 14:52:51 2016 +0100
# Node ID bd5f195755b19ff9ab6c26851c25e2832cf8033a
# Parent b0bf3985ec934d3e00219dd2afc1436d249c6e77
Remove skip_filename()
As skip_filename isn't used any more, remove the code.
diff -r b0bf3985ec93 -r bd5f195755b1 tboot/common/cmdline.c
--- a/tboot/common/cmdline.c Tue Feb 23 14:50:16 2016 +0100
+++ b/tboot/common/cmdline.c Tue Feb 23 14:52:51 2016 +0100
@@ -589,23 +589,6 @@
return true;
}
-const char *skip_filename(const char *cmdline)
-{
- if ( cmdline == NULL || *cmdline == '\0' )
- return cmdline;
-
- /* strip leading spaces, file name, then any spaces until the next
- non-space char (e.g. " /foo/bar baz" -> "baz"; "/foo/bar" -> "")*/
- while ( *cmdline != '\0' && isspace(*cmdline) )
- cmdline++;
- while ( *cmdline != '\0' && !isspace(*cmdline) )
- cmdline++;
- while ( *cmdline != '\0' && isspace(*cmdline) )
- cmdline++;
- return cmdline;
-}
-
-
/*
* Local variables:
* mode: C
diff -r b0bf3985ec93 -r bd5f195755b1 tboot/include/cmdline.h
--- a/tboot/include/cmdline.h Tue Feb 23 14:50:16 2016 +0100
+++ b/tboot/include/cmdline.h Tue Feb 23 14:52:51 2016 +0100
@@ -60,7 +60,6 @@
extern bool get_linux_vga(int *vid_mode);
extern bool get_linux_mem(uint64_t *initrd_max_mem);
-extern const char *skip_filename(const char *cmdline);
extern uint8_t get_loglvl_prefix(char **pbuf, int *len);
#endif /* __CMDLINE_H__ */
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
tboot-devel mailing list
tboot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tboot-devel
