It has always bothered me that src/sys/sys/envsys.h exposes several internal data structures to userland. It seems to me that the only items from this header file that should really be exported are

* the definitions for the various IOCTLs
* the definitions for the sensor units
* the definitions for the sensor states/values
* the definitions for the legacy "struct envsys_tre_data"

The "struct sysmon_envsys_lim" and "struct envsys_data" should be moved into src/sys/dev/sysmon/sysmon_envsysvar.h along with the related internal flags and properties definitions.

Comments?


-------------------------------------------------------------------------
|   Paul Goyette   | PGP DSS Key fingerprint: |  E-mail addresses:      |
| Customer Service | FA29 0E3B 35AF E8AE 6651 |  paul at whooppee.com   |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------

Reply via email to