On Fri, Oct 21, 2011 at 07:45:36AM -0400, Thor Lancelot Simon wrote:
> On Fri, Oct 21, 2011 at 11:57:33AM +0200, Manuel Bouyer wrote:
> > >
> > > - the type "struct ufs_quota_entry" is apparently, despite its name
> > > and (parts of) its usage pattern, meant to be fs-independent.
> >
> > true. More precisely it describes the traditionnal quota properties
> > we have seen on unix filesystems for some time (ufs is unix filesystems,
> > isn't it ?)
>
> This is bound to cause tremendous confusion. Can we please change the name
> to "fs_quota_entry"? Consider what will happen when (or if) there is a
> "zfs_quota_entry" or an "lfs_quota_entry": it will look to anyone reading
> the code as if ufs_quota_entry is specific to the ufs layer and the
> filesystems that use it. Not good.
ufs_quota_entry is part of the API now, and at last netatalk started using
it. I think I patched another tool in pkgsrc, but I don't remember which one,
and I don't know if the patch has been integrated upstream.
maybe we could #define ufs_quota_entry fs_quota_entry for the time being ?
--
Manuel Bouyer <bou...@antioche.eu.org>
NetBSD: 26 ans d'experience feront toujours la difference
--
