Kengo NAKAHARA <k-nakah...@iij.ad.jp> wrote: > Sorry, I typo the patch URL. > > (2014/08/20 18:06), Kengo NAKAHARA wrote: > > and here is the patch > > http://knakahara.github.io/patches/netbsd/irq-affinity-initctl.patch > > http://knakahara.github.io/patches/netbsd/irq-affinity-intrctl.patch
Have to admit that I did not read the patch carefully, but why io_interrupt_sources_lock is __cpu_simple_lock? Why not to re-use cpu_lock? The locking itself does not seem to be correct either. How much of the IRQ affinity code (in x86/intr.c) is actually MD? It seems that a lot of that can be made MI (think of kern/subr_intr.c). Also, please do not forget to add the BSD license text for the newly created files. -- Mindaugas
