Hi riastradh@n.o, On 2016/02/02 9:53, Taylor R Campbell wrote: > Date: Mon, 1 Feb 2016 14:58:05 +0900 > From: Ryota Ozaki <ozak...@netbsd.org> > > On Sat, Jan 30, 2016 at 12:43 AM, Taylor R Campbell > <riastr...@netbsd.org> wrote: > > Date: Fri, 29 Jan 2016 17:39:13 +0900 > > From: Ryota Ozaki <ozak...@netbsd.org> > > > > I'm thinking applying psref to bridge member list > > that is now using its own version of similar mechanism > > (psz + refcount). > > > > Nice! That sounds like a good application to test, since most of the > > work has been done already and it's mainly a matter of replacing a > > refcount by a psref. > > I'm happy if there is a patch of psref.c to -current :) > > Here you go, attached! I even compile-tested this one.
I have a question about the patch. Is "target->prt_draining = false;" required at the end of psref_target_drain()? Or, shouldn't psref_target_drain() be called twice? My kernel paniced with the following message. ==================== kernel diagnostic assertion "!target->prt_draining" failed: file "sys/kern/subr_psref.c", line 395 ==================== I am implementing ip_encap with passive reference. I use passive reference to exclude encaptab list because ep->func (in encap[46]_lookup) can sleep. Could you comment about my question? Thanks, -- ////////////////////////////////////////////////////////////////////// Internet Initiative Japan Inc. Device Engineering Section, Core Product Development Department, Product Division, Technology Unit Kengo NAKAHARA <k-nakah...@iij.ad.jp>
