Hi,
I want to uniform IFQ_ENQUEUE arguments whether ALTQ is defined or not.
# And I also want to eliminate ALTQ_DECL and ALTQ_COMMA macros...
So, I make struct altq_pktattr from IFQ_CLASSIFY and IFQ_ENQUEUE argument
to m_tag. Here is the patch.
http://netbsd.org/~knakahara/altq-caller-refactor/altq-caller-refactor.patch
In above patch, I fix performance issue by the following two ways.
- make ALTQ's m_tag pool cache
- inline altq_*_pattr functions
Without these two fixes, the enabled ALTQ throughput degraded about 10%.
However, with these two fixes, the throughput is almost the same
performance.
Could you comment this patch? Any comments are welcome. In particular,
comments compared with the following thread.
http://mail-index.netbsd.org/tech-kern/2016/02/19/msg020238.html
Thanks,
--
//////////////////////////////////////////////////////////////////////
Internet Initiative Japan Inc.
Device Engineering Section,
Core Product Development Department,
Product Division,
Technology Unit
Kengo NAKAHARA <k-nakah...@iij.ad.jp>
