On Fri, Aug 17, 2018 at 12:59:57PM +0200, Jaromir Dolecek wrote:
> 
> yes, one of the problems is the code happily handles stale bufs. it does not 
> clear the buf pointer when the response is already handled. we should add 
> some KASSERTs there for this and clear the response structure on reuse. 

yes, that also makes it clear wether a request is processed twice (and
not just a buffer).

> also DPRINTF() in the loop assume bp is balid so it uses stale pointer for 
> disk flush ...

It also tries to handle invalid operation codes, but then assumes other
data (i.e. the buffer pointer) is valid.

Greetings,
-- 
                                Michael van Elst
Internet: mlel...@serpens.de
                                "A potential Snark may lurk in every tree."

Reply via email to