In article <24279.1548106...@splode.eterna.com.au>, matthew green <m...@eterna.com.au> wrote: >> > @@ -472,6 +472,9 @@ >> > const char *bootname = device_xname(bdv); >> > size_t len = strlen(bootname); >> > >> > + if (bdv == NULL) >> > + return 0; >> > + >> >> This looked suspicious, even before I read the code. >> >> The question is if it is ever legitimate for bdv to be NULL. > >infact, bdv has already been dereferenced at this point: >the assignment to bootname 3 lines up.
Yes, that change should be reverted. christos
