On Tue, Jun 15, 2021 at 1:57 PM Christos Zoulas <chris...@zoulas.com> wrote: > > > > > On Jun 15, 2021, at 4:22 AM, Piyush Sachdeva <piyushsachdeva...@gmail.com> > > wrote: > > > >>> Progress Update 1 (Week 2)- > >>> Contrary to the timeline provided, I started working within the user-land. > >>> (src/lib/libc/gen/posix_spawn_fileactions.c, src/include/spawn.h, > >>> src/sys/sys/spawn.h > >>> The modifications made to the files can be found at: > >>> https://github.com/cosmologistPiyush/posix_spawn-chdir > >>> > >>> > >>> As most of the work in the user-land is done, > >>> it is my goal to work in the kernel-space for the next three weeks. > > > >> Good progress. It is probably better to mimick the original NetBSD tree > >> structure in userland and commit your changes on top of a baseline that > >> comes unmodified from NetBSD so that you can produce a diff that directly > >> applies to the NetBSD tree. > > > > Thank you! > > I will get my commits in order asap. > > > >> You also need to write unit-tests for userland :-) > > > > My initial plan was to write test cases during weeks 6&7, > > given I am not too fluent with unit testing. > > However, if the test cases are required right away, > > then I will start working on them as well. > > No, you don't need to write the unit-tests right now. I was merely addressing > the comment that "most of the work in the user-land is done", because writing > proper unit-tests is more work than adding the APIs.
Duly noted. Thank you, Piyush