Valery Ushakov <u...@stderr.spb.ru> writes: > I'm still not entirely sure, why XEN kernels include GENERIC.local in > the first place though. If one needs a fragile maze of includes just > to avoid a few lines being copy-pasted, that doesn't feel like a win.
Having FOO include FOO.local is fine, but we still need a local include file that is included by substantially every kernel. The point is that if I decide that on my systems, I want some device that isn't on by default, or to tweak something, and I want it on everything, it should be easy. In particular, I think it's normal to flip back and forth between GENERIC and XEN3_DOM0 on the same machine, and those feel like they are doing the same thing, modulo expecting a hypervisor. Arguably, XEN3_DOM0 should just include GENERIC and then have any dom0 stuff added and some no stuff. This feels like "we shouldn't have XEN kernels include what they have included for years, because we found a latent config bug".
