I don't like detach. bioctl is a generic tool and the intent of that command is to "delete" a logical disk of a "controller". The fact that softraid detaches the disk is a side-effect. On mfi, for example, that is a pretty destructive command.
On Mon, Sep 13, 2010 at 03:10:12PM +0100, Jason McIntyre wrote: > On Sun, Sep 12, 2010 at 11:00:47PM -0700, Chris Palmer wrote: > > Jason McIntyre writes: > > > > > ok, my diff below tries to collect the various bits of feedback. stuff i > > > haven't taken: > > > > Thanks for doing this. > > > > > - delete -> detach, for reasons given by marco > > > > I'd still like to reconsider this. > > > > if marco indicates he's alright with it, i'll add it. > > > > - `` -> "; i don't think it's worth changing > > > > But it looks silly with the other style of quotes right next to it in the > > page: > > > > ``Unused'', promote it to being a ``Hot Spare''. > > > > -h Where necessary, produce "human-readable" output. Use unit > > suffix- > > > > ok, i will make this change. > > i'll hold off from commit to see about the delete/detach thing... > > jmc
