On 2013/11/20 11:32, Martin Pieuchot wrote: > On 20/11/13(Wed) 10:16, Stuart Henderson wrote: > > On 2013/11/20 10:10, Martin Pieuchot wrote: > > > This one is not under _KERNEL but it's used at only one place and > > > if a port use it, it should probably define it by itself. > > > > This is used in at least kde-workspace and embedded copies of slirp > > (the ones I know about so far are emulators/qemu and emulators/BasiliskII). > > > > It's easy enough to patch existing users in ports now, but removing it > > makes things more difficult for people porting something else later > > which happens to use it - so I wonder what's the reasoning behind this? > > (if it's a namespace issue, I don't think that's valid given that it's > > widely available - xnu, solaris, free/net/open/dfbsd and derivatives). > > Simply cleaning, to unify our code base. > > > btw if people want a quick way to search for things in common source code, > > http://codesearch.debian.net/ is useful. > > Nice tool, thanks for the hint. > > So here's an updated version that keeps the define for userland, would > it be ok?
After some test builds and a careful look at where the #ifdef's are, I've revised my opinion, nothing in ports does actually use it ;) As a result, I'm OK with either version of this.
