Henning Brauer <lists-openbsdtech <at> bsws.de> writes: > congratulations, that is close to unauditable. > > i put the vlan and the !vlan case next to each other ON PURPOSE. both > cases add an ethernet header, one with a few extra fields, one > without. Having that next to each other makes it f***ing obvious both > cases are identical, except the vlan case filling the 3 extra fields.
Another approach is to use delayed pattern (like you did for cksums): compute flags, a set of header assembly conditions, and, later on, keep method call logic obvious using that flags.