On 21/04/14(Mon) 11:14, Claudio Jeker wrote:
> [...]
> 
> Would it make sense to put this into a vlan_encap function so that we can
> reduce the amount of layer violation here?

I think it makes sense.

> #if NVLAN > 0
>       if (ifp->if_type == IFT_L2VLAN)
>               return vlan_encap(ifp, m);
> #endif
> 
> We could also add a ifp->if_encap function pointer but if it is just for
> vlan(4) I see no point in it.

I totally agree.  If it's only for vlan(4), then I'd leave for later
if/when a better pattern/need appears. 

Reply via email to