On Fri, Sep 05, 2014 at 03:10:01PM -0400, Brad Smith wrote: > On Tue, Sep 02, 2014 at 07:20:30AM -0400, Brad Smith wrote: > > On Tue, Sep 02, 2014 at 06:28:48AM -0400, Brad Smith wrote: > > > Add some feature flags and store in the softc the various max Jumbo frame > > > sizes > > > for the different generations of chips. No behavioral change. > > > > > > Tested with.. > > > > > > re0 at pci2 dev 0 function 0 "Realtek 8168" rev 0x03: RTL8168D/8111D > > > (0x2800) > > > re0 at pci2 dev 0 function 0 "Realtek 8168" rev 0x0c: RTL8168G/8111G > > > (0x4c00) > > > > > > OK? > > > > Fix a typo with RL_FLAG_HWIM. > > So store the PCI id in the sc_product field instead. The CardBus bit is not > strictly necessary but I'd rather be consistent for both bus frontends for > now especially if I happen to use this field for anything else in the future. >
> + pci_vendor_id_t sc_product; OK, but this should be uint16_t as re.c should really have Index: re.c =================================================================== RCS file: /cvs/src/sys/dev/ic/re.c,v retrieving revision 1.155 diff -u -p -r1.155 re.c --- re.c 22 Jul 2014 13:12:12 -0000 1.155 +++ re.c 6 Sep 2014 03:53:02 -0000 @@ -121,6 +121,8 @@ #include <sys/timeout.h> #include <sys/socket.h> +#include <machine/bus.h> + #include <net/if.h> #include <net/if_dl.h> #include <net/if_media.h> @@ -141,9 +143,6 @@ #include <dev/mii/mii.h> #include <dev/mii/miivar.h> - -#include <dev/pci/pcireg.h> -#include <dev/pci/pcivar.h> #include <dev/ic/rtl81x9reg.h> #include <dev/ic/revar.h>
