several kernel files have a dependency on unistd.h but fail to include it. (indirect include through file.h, which i'd like to eliminate.)
if you need the file, include it. and udf_subr.c at least is one file that doesn't need unistd.h for reference, here's the sys/file.h diff, then the big .c diff. Index: sys/file.h =================================================================== RCS file: /cvs/src/sys/sys/file.h,v retrieving revision 1.32 diff -u -p -r1.32 file.h --- sys/file.h 10 Jul 2014 14:33:18 -0000 1.32 +++ sys/file.h 2 Nov 2014 03:51:12 -0000 @@ -33,7 +33,6 @@ */ #include <sys/fcntl.h> -#include <sys/unistd.h> #ifdef _KERNEL #include <sys/queue.h> Index: kern/kern_fork.c =================================================================== RCS file: /cvs/src/sys/kern/kern_fork.c,v retrieving revision 1.174 diff -u -p -r1.174 kern_fork.c --- kern/kern_fork.c 8 Sep 2014 01:47:06 -0000 1.174 +++ kern/kern_fork.c 2 Nov 2014 03:55:10 -0000 @@ -59,6 +59,7 @@ #include <sys/mman.h> #include <sys/ptrace.h> #include <sys/atomic.h> +#include <sys/unistd.h> #include <sys/syscallargs.h> Index: kern/spec_vnops.c =================================================================== RCS file: /cvs/src/sys/kern/spec_vnops.c,v retrieving revision 1.79 diff -u -p -r1.79 spec_vnops.c --- kern/spec_vnops.c 13 Sep 2014 16:06:37 -0000 1.79 +++ kern/spec_vnops.c 2 Nov 2014 03:53:50 -0000 @@ -51,6 +51,7 @@ #include <sys/dkio.h> #include <sys/malloc.h> #include <sys/specdev.h> +#include <sys/unistd.h> #define v_lastr v_specinfo->si_lastr Index: kern/vfs_lockf.c =================================================================== RCS file: /cvs/src/sys/kern/vfs_lockf.c,v retrieving revision 1.17 diff -u -p -r1.17 vfs_lockf.c --- kern/vfs_lockf.c 10 Apr 2012 09:07:20 -0000 1.17 +++ kern/vfs_lockf.c 2 Nov 2014 03:52:03 -0000 @@ -44,6 +44,7 @@ #include <sys/pool.h> #include <sys/fcntl.h> #include <sys/lockf.h> +#include <sys/unistd.h> struct pool lockfpool; Index: kern/vfs_syscalls.c =================================================================== RCS file: /cvs/src/sys/kern/vfs_syscalls.c,v retrieving revision 1.211 diff -u -p -r1.211 vfs_syscalls.c --- kern/vfs_syscalls.c 22 Oct 2014 21:43:16 -0000 1.211 +++ kern/vfs_syscalls.c 2 Nov 2014 03:54:10 -0000 @@ -55,6 +55,7 @@ #include <sys/dkio.h> #include <sys/disklabel.h> #include <sys/ktrace.h> +#include <sys/unistd.h> #include <sys/syscallargs.h> Index: kern/vfs_vnops.c =================================================================== RCS file: /cvs/src/sys/kern/vfs_vnops.c,v retrieving revision 1.78 diff -u -p -r1.78 vfs_vnops.c --- kern/vfs_vnops.c 13 Jul 2014 15:00:40 -0000 1.78 +++ kern/vfs_vnops.c 2 Nov 2014 03:54:27 -0000 @@ -56,6 +56,7 @@ #include <sys/poll.h> #include <sys/filedesc.h> #include <sys/specdev.h> +#include <sys/unistd.h> int vn_read(struct file *, off_t *, struct uio *, struct ucred *); int vn_write(struct file *, off_t *, struct uio *, struct ucred *); Index: isofs/cd9660/cd9660_vnops.c =================================================================== RCS file: /cvs/src/sys/isofs/cd9660/cd9660_vnops.c,v retrieving revision 1.67 diff -u -p -r1.67 cd9660_vnops.c --- isofs/cd9660/cd9660_vnops.c 14 Sep 2014 14:17:25 -0000 1.67 +++ isofs/cd9660/cd9660_vnops.c 2 Nov 2014 03:55:49 -0000 @@ -56,6 +56,7 @@ #include <sys/cdio.h> #include <sys/poll.h> #include <sys/specdev.h> +#include <sys/unistd.h> #include <miscfs/fifofs/fifo.h> Index: isofs/udf/udf_subr.c =================================================================== RCS file: /cvs/src/sys/isofs/udf/udf_subr.c,v retrieving revision 1.22 diff -u -p -r1.22 udf_subr.c --- isofs/udf/udf_subr.c 16 Apr 2011 03:21:16 -0000 1.22 +++ isofs/udf/udf_subr.c 2 Nov 2014 03:49:30 -0000 @@ -36,7 +36,6 @@ #include <sys/mount.h> #include <sys/vnode.h> #include <sys/dirent.h> -#include <sys/unistd.h> #include <sys/disklabel.h> #include <isofs/udf/ecma167-udf.h> Index: isofs/udf/udf_vnops.c =================================================================== RCS file: /cvs/src/sys/isofs/udf/udf_vnops.c,v retrieving revision 1.55 diff -u -p -r1.55 udf_vnops.c --- isofs/udf/udf_vnops.c 12 Jul 2014 18:50:00 -0000 1.55 +++ isofs/udf/udf_vnops.c 2 Nov 2014 03:55:33 -0000 @@ -46,9 +46,9 @@ #include <sys/vnode.h> #include <sys/dirent.h> #include <sys/queue.h> -#include <sys/unistd.h> #include <sys/endian.h> #include <sys/specdev.h> +#include <sys/unistd.h> #include <isofs/udf/ecma167-udf.h> #include <isofs/udf/udf.h> Index: miscfs/fifofs/fifo_vnops.c =================================================================== RCS file: /cvs/src/sys/miscfs/fifofs/fifo_vnops.c,v retrieving revision 1.42 diff -u -p -r1.42 fifo_vnops.c --- miscfs/fifofs/fifo_vnops.c 9 Oct 2014 16:36:36 -0000 1.42 +++ miscfs/fifofs/fifo_vnops.c 2 Nov 2014 03:53:38 -0000 @@ -47,6 +47,8 @@ #include <sys/malloc.h> #include <sys/poll.h> #include <sys/un.h> +#include <sys/unistd.h> + #include <miscfs/fifofs/fifo.h> /* Index: msdosfs//msdosfs_vnops.c =================================================================== RCS file: /cvs/src/sys/msdosfs/msdosfs_vnops.c,v retrieving revision 1.95 diff -u -p -r1.95 msdosfs_vnops.c --- msdosfs//msdosfs_vnops.c 10 Aug 2014 09:23:06 -0000 1.95 +++ msdosfs//msdosfs_vnops.c 2 Nov 2014 03:53:19 -0000 @@ -67,6 +67,7 @@ #include <sys/dirent.h> /* defines dirent structure */ #include <sys/lockf.h> #include <sys/poll.h> +#include <sys/unistd.h> #include <msdosfs/bpb.h> #include <msdosfs/direntry.h> Index: nfs/nfs_serv.c =================================================================== RCS file: /cvs/src/sys/nfs/nfs_serv.c,v retrieving revision 1.97 diff -u -p -r1.97 nfs_serv.c --- nfs/nfs_serv.c 12 Jul 2014 18:43:52 -0000 1.97 +++ nfs/nfs_serv.c 2 Nov 2014 03:52:58 -0000 @@ -70,6 +70,8 @@ #include <sys/kernel.h> #include <sys/pool.h> #include <sys/queue.h> +#include <sys/unistd.h> + #include <ufs/ufs/dir.h> #include <nfs/nfsproto.h> Index: ufs/ext2fs/ext2fs_vnops.c =================================================================== RCS file: /cvs/src/sys/ufs/ext2fs/ext2fs_vnops.c,v retrieving revision 1.67 diff -u -p -r1.67 ext2fs_vnops.c --- ufs/ext2fs/ext2fs_vnops.c 13 Jul 2014 16:59:35 -0000 1.67 +++ ufs/ext2fs/ext2fs_vnops.c 2 Nov 2014 03:52:17 -0000 @@ -56,6 +56,7 @@ #include <sys/pool.h> #include <sys/signalvar.h> #include <sys/specdev.h> +#include <sys/unistd.h> #include <miscfs/fifofs/fifo.h> Index: ufs/ufs/ufs_vnops.c =================================================================== RCS file: /cvs/src/sys/ufs/ufs/ufs_vnops.c,v retrieving revision 1.115 diff -u -p -r1.115 ufs_vnops.c --- ufs/ufs/ufs_vnops.c 12 Jul 2014 18:44:01 -0000 1.115 +++ ufs/ufs/ufs_vnops.c 2 Nov 2014 03:52:40 -0000 @@ -56,6 +56,7 @@ #include <sys/event.h> #include <sys/poll.h> #include <sys/specdev.h> +#include <sys/unistd.h> #include <miscfs/fifofs/fifo.h>
