On Sun, Nov 02, 2014 at 01:08:46AM -0500, Ted Unangst wrote: > several kernel files have a dependency on unistd.h but fail to include > it. (indirect include through file.h, which i'd like to eliminate.) > > if you need the file, include it. > > and udf_subr.c at least is one file that doesn't need unistd.h > > for reference, here's the sys/file.h diff, then the big .c diff.
The diff looks good though you seem to have missed some according to a run of include-what-you-use: missing removals kern/kern_event.c nfs/nfs_kq.c missing additions kern/tty.c for _POSIX_VDISABLE You might want to do builds on a least a few platforms to test as different platforms have different indirect includes...
