> From: "Ted Unangst" <t...@tedunangst.com>
> Date: Sat, 29 Aug 2015 18:38:45 -0400
>
> Mark Kettenis wrote:
> > This diff is purely mechanical. This means that it also changes some
> > pool_allocator_nointr into pool_allocator_single where the intention
> > was to signal that the pool would never be used in interrupt context.
> > However, using pool_allocator_single in those cases isn't a big deal
> > as there is no downside. But we could consider changing those into
> > passing NULL and setting the PR_WAITOK flag to the pool_init calls in
> > question.
>
> I would prefer we do this (NULL and WAITOK). I've done some before as I came
> across them, but didn't scan the whole tree.
This converts sys/isofs. These pools are clearly not used in
interrupt handlers since all pool_get calls specify PR_WAITOK already.
ok?
Index: udf/udf_vfsops.c
===================================================================
RCS file: /cvs/src/sys/isofs/udf/udf_vfsops.c,v
retrieving revision 1.45
diff -u -p -r1.45 udf_vfsops.c
--- udf/udf_vfsops.c 14 Mar 2015 03:38:50 -0000 1.45
+++ udf/udf_vfsops.c 30 Aug 2015 17:14:55 -0000
@@ -102,12 +102,12 @@ const struct vfsops udf_vfsops = {
int
udf_init(struct vfsconf *foo)
{
- pool_init(&udf_trans_pool, MAXNAMLEN * sizeof(unicode_t), 0, 0, 0,
- "udftrpl", &pool_allocator_nointr);
- pool_init(&unode_pool, sizeof(struct unode), 0, 0, 0,
- "udfndpl", &pool_allocator_nointr);
- pool_init(&udf_ds_pool, sizeof(struct udf_dirstream), 0, 0, 0,
- "udfdspl", &pool_allocator_nointr);
+ pool_init(&udf_trans_pool, MAXNAMLEN * sizeof(unicode_t), 0, 0,
+ PR_WAITOK, "udftrpl", NULL);
+ pool_init(&unode_pool, sizeof(struct unode), 0, 0,
+ PR_WAITOK, "udfndpl", NULL);
+ pool_init(&udf_ds_pool, sizeof(struct udf_dirstream), 0, 0,
+ PR_WAITOK, "udfdspl", NULL);
return (0);
}
