On Sun, Sep 27, 2015 at 02:39:39PM +0200, Theo Buehler wrote:
> Now that there is radiusd(8) in base, I suggest the following changes:
>
> * add back the manual section number to 'Xr radiusd' in login_radius.8
> and in login.conf.5
>
> * remove a sentence from CAVEATS which is no longer true. I don't
> think that `.Xr packages 7' is necessary.
>
> * the grammar of one sentence seems odd, I added a 'to' (second hunk).
>
just a note on this last point:
> Index: libexec/login_radius/login_radius.8
> ===================================================================
> RCS file: /cvs/src/libexec/login_radius/login_radius.8,v
> retrieving revision 1.12
> diff -u -p -r1.12 login_radius.8
> --- libexec/login_radius/login_radius.8 14 Aug 2013 08:39:31 -0000
> 1.12
> +++ libexec/login_radius/login_radius.8 27 Sep 2015 12:34:20 -0000
> @@ -49,7 +49,7 @@
> The
> .Nm
> utility contacts the
> -.Xr radiusd
> +.Xr radiusd 8
> daemon to authenticate a
> .Ar user .
> If no
> @@ -60,8 +60,8 @@ When executed as the name
> .Pa login_ Ns Ar style ,
> .Nm
> will request
> -.Xr radiusd
> -use the authentication specified by
> +.Xr radiusd 8
> +to use the authentication specified by
there are various patterns:
ask someone to do something
request something of someone
request someone do something
so what's there is perfectly fine. i'm not sure if it's even correct to
"request someone to do something" - i certainly wouldn;t use it.
jmc
> .Ar style .
> .Pp
> The options are as follows:
> @@ -95,7 +95,7 @@ server shared_secret
> .Pp
> It is expected that rather than requesting the radius style directly
> (in which case the
> -.Xr radiusd
> +.Xr radiusd 8
> server uses a default style)
> that
> .Nm
> @@ -111,7 +111,7 @@ to both of those names.
> Now when the user requests one of those authentication styles,
> .Nm
> will automatically forward the request to the remote
> -.Xr radiusd
> +.Xr radiusd 8
> and request it do the requested style of authentication.
> .Sh LOGIN.CONF VARIABLES
> The
> @@ -154,11 +154,6 @@ list of radius servers and their associa
> .Xr login 1 ,
> .Xr login.conf 5
> .Sh CAVEATS
> -.Ox
> -does not ship with a radius server in the default install, however
> -several are available via
> -.Xr packages 7 .
> -.Pp
> For
> .Nm
> to function, the
> Index: share/man/man5/login.conf.5
> ===================================================================
> RCS file: /cvs/src/share/man/man5/login.conf.5,v
> retrieving revision 1.60
> diff -u -p -r1.60 login.conf.5
> --- share/man/man5/login.conf.5 24 Sep 2015 13:24:59 -0000 1.60
> +++ share/man/man5/login.conf.5 27 Sep 2015 12:34:20 -0000
> @@ -542,7 +542,7 @@ and
> are provided for use by programs like
> .Xr ftpd 8
> and
> -.Xr radiusd .
> +.Xr radiusd 8 .
> If no service type is specified,
> .Li login
> is used.
>
