On Sat, Nov 07, 2015 at 05:57:55PM -0500, Ted Unangst wrote:
> > Also, I'm seeing a couple "could not allocate memory" messages added to
> > *snprintf() functions. They write to a supplied buffer, no?
>
> Good catch.
Will update that one, thanks.
> > > > + i = vsnprintf(str, len, fmt, ap);
> > > > va_end(ap);
> > > >
> > > > - if (i == -1 || i >= (int)size)
> > > > - fatal("xsnprintf: overflow");
> > > > + if (i < 0 || i >= (int)len)
> > > > + fatal("xsnprintf: could not allocate memory");
>
> This change (among a few others) is wrong.
Could you give me a bit of detail what's wrong here?
Can update the diff when you give me details on "a few others", too.
