On Mon, Feb 01, 2016 at 05:17:03PM +0100, Michal Mazurek wrote:
> Meaningful error messages:
>
>               mntbuf = calloc(argc, sizeof(struct statfs));
>               if (mntbuf == NULL)
> -                     err(1, NULL);
> +                     err(1, "calloc");

I disagree with the changes in this patch.  If either malloc or calloc
fails it will typically set errno to ENOMEM, so you'll

df: Cannot allocate memory

I don't think adding the information that it was malloc or calloc that
failed is helpful at all.

I can only speak for myself but I'd appreciate if you would send
unrelated patches in separate mails.

Reply via email to