On Mon, Feb 01, 2016 at 05:41:25PM +0100, Theo Buehler wrote: > On Mon, Feb 01, 2016 at 05:17:03PM +0100, Michal Mazurek wrote: > > Meaningful error messages: > > > > mntbuf = calloc(argc, sizeof(struct statfs)); > > if (mntbuf == NULL) > > - err(1, NULL); > > + err(1, "calloc"); > > I disagree with the changes in this patch. If either malloc or calloc > fails it will typically set errno to ENOMEM, so you'll > > df: Cannot allocate memory > > I don't think adding the information that it was malloc or calloc that > failed is helpful at all.
Well, to be fair, it's done this way in the malloc manual, but still I'm not in favor of changing this. The header cleanup is ok tb@ if anyone wants to commit that. I can't judge the correctness of the change of the comment. There never was a fsmask variable in df.c since it was imported.
