On Wed, Dec 07, 2016 at 02:49:55PM +0100, Rafael Zalamena wrote:
> ---snipped---
> 

Actually the code below is not wrong, there are some scenarios where you
need this to make relayed DHCP to work. I'm not touching the part I noted
before.

The diff that I sent before still stands and has nothing to do with this
note.

> -------
> Note:
> While testing this I noticed that even though the server socket is sending
> the wrong source port, the dhcp server doesn't care about it and it works.
> But this can be easily fixed by changing this line in dhcrelay.c:
> ...
> main() {
> ...
>       laddr.sin_port = server_port;
> ...
> 
> to
>       laddr.sin_port = client_port;
> 
> I'll fix this in another diff.
> ------

Reply via email to