Rafael Zalamena <[email protected]> writes:

> On Thu, Dec 08, 2016 at 06:59:18PM +0100, Jeremie Courreges-Anglas wrote:
>> Rafael Zalamena <[email protected]> writes:
>> 
>> [...]
>> 
>> >> Another problem: the relay->server code uses send(2) on a connected
>> >> socket and thus has no destination IP issue.  But the relay->client path
>> >> now uses the source address from the server->relay packet.  I think
>> >> we should keep using interfaces->primary_address here...
>> 
>> [...]
>> 
>> > Here is the new diff with the improvements, ok?
>> 
>> Thanks.  Your diff still makes use of the server's source address to
>> relay the BOOTREPLY to the client.  I'd say that this is an important
>> change and I'm not sure at all whether it is desirable.  It surely can't
>> be committed as part of a cleanup diff.
>
> Sorry, I forgot about that one. I got a multi relayed setup and it does
> make a difference.
>
> Here is a new diff with your suggestion.

Works fine here.

> ok?

ok jca@

BTW you can now kill struct iaddr.

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to