On Tue, 30 Oct 2018 22:29:01 -0700, Mike Larkin <[email protected]> wrote:
> > - if (disk->base->clustersz != disk->clustersz) {
> > - log_warn("%s: all disks must share clustersize",
> > + fatal("%s: could not open %s", basepath, __func__);
>
> is this right?
>
> > + if (qc2_open(disk->base, fds + 1, nfd - 1) == -1)
> > + fatalx("%s: could not open %s", basepath, __func__);
>
> same
>
> > + if (disk->base->clustersz != disk->clustersz)
> > + fatalx("%s: all disk parts must share clustersize",
> > __func__);
> > - goto error;
> > - }
> > - }
Good question. I think from earlier discussion, we wanted to fail if we could
not open a disk image -- especially since these ones are actually *parts* of
a disk image, meaning that we've got a corrupt image.
I can easily change these back to warns + error returns.
--
Ori Bernstein
