On Tue, 30 Oct 2018 23:01:50 -0700, Mike Larkin <mlar...@azathoth.net> wrote:
> On Tue, Oct 30, 2018 at 10:41:21PM -0700, o...@eigenstate.org wrote:
> > > On Tue, Oct 30, 2018 at 10:32:37PM -0700, Ori Bernstein wrote:
> > >> On Tue, 30 Oct 2018 22:29:01 -0700, Mike Larkin <mlar...@azathoth.net>
> > >> wrote:
> > >>
> > >> > > - if (disk->base->clustersz != disk->clustersz) {
> > >> > > - log_warn("%s: all disks must share clustersize",
> > >> > > + fatal("%s: could not open %s", basepath,
> > >> > > __func__);
> > >> >
> > >> > is this right?
> > >> >
> > >> > > + if (qc2_open(disk->base, fds + 1, nfd - 1) == -1)
> > >> > > + fatalx("%s: could not open %s", basepath,
> > >> > > __func__);
> > >> >
> > >> > same
> > >> >
> > >> > > + if (disk->base->clustersz != disk->clustersz)
> > >> > > + fatalx("%s: all disk parts must share
> > >> > > clustersize",
> > >> > > __func__);
> > >> > > - goto error;
> > >> > > - }
> > >> > > - }
> > >>
> > >> Good question. I think from earlier discussion, we wanted to fail if we
> > >> could
> > >> not open a disk image -- especially since these ones are actually
> > >> *parts* of
> > >> a disk image, meaning that we've got a corrupt image.
> > >>
> > >> I can easily change these back to warns + error returns.
> > >>
> > >> --
> > >> Ori Bernstein
> > >
> > > I was referring to the argument order.
> >
> > Oh, that's obviously wrong. Updated.
> >
>
> with that fix, go for it. we can hack on it further in-tree.
>
Anyone want to give me a second ok?
--
Ori Bernstein
