Why not delete the 2nd line? I mean isn't it obvious? I'd expect some archeology to figure out how this bug got introduced, rather than a diff which you obviously don't know the result of.
> Remove useless assignment, value is overwritten right after being set. > > Coverity CID 1453008. > > Comments? OK? > > Index: dev/pci/bktr/bktr_core.c > =================================================================== > RCS file: /cvs/src/sys/dev/pci/bktr/bktr_core.c,v > retrieving revision 1.39 > diff -u -p -r1.39 bktr_core.c > --- dev/pci/bktr/bktr_core.c 28 Apr 2018 15:44:59 -0000 1.39 > +++ dev/pci/bktr/bktr_core.c 17 Nov 2018 21:24:29 -0000 > @@ -2864,7 +2864,6 @@ yuvpack_prog( bktr_ptr_t bktr, char i_fl > OUTB(bktr, BKTR_COLOR_CTL, INB(bktr, BKTR_COLOR_CTL) | > BT848_COLOR_CTL_RGB_DED | BT848_COLOR_CTL_GAMMA); > OUTB(bktr, BKTR_ADC, SYNC_LEVEL); > > - bktr->capcontrol = 1 << 6 | 1 << 4 | 1 << 2 | 3; > bktr->capcontrol = 3 << 2 | 3; > > dma_prog = (u_int *) bktr->dma_prog; >
