On Sat, Nov 17, 2018 at 04:36:49PM -0700, Theo de Raadt wrote: > Why not delete the 2nd line? > > I mean isn't it obvious? I'd expect some archeology to figure > out how this bug got introduced, rather than a diff which you > obviously don't know the result of.
Fair enough, I realize it indeed looks that way if I don't mention anything. Before sending the diff I found out that both assignements are in our tree since the driver got imported from FreeBSD in 2001 and remained untouched since r1.1. I then checked the actual state of yuvpack_prog() in FreeBSD and only the second assignment remains. The second assignment in its current form got introduced in FreeBSD in 1997 with r29233 [1], when syncinc the driver. The first assignment got removed in 2017 with r314147 [2]. [1]: https://svnweb.freebsd.org/base?view=revision&revision=29233 [2]: https://svnweb.freebsd.org/base?view=revision&revision=314147
