The example in the manual implies that the download command also selects
it:

        # ldomctl init-system ldom.conf
        # cd ..
        # ldomctl delete openbsd
        # ldomctl download openbsd
        # ldomctl list
        factory-default [current]
        openbsd [next]

But `ldomctl select openbsd' is required between downloading and listing
to get this result - at least on my T4 machine `download' never selected
any configuration, however I vaguely remember that this was the case
with older machines.

kettenis: Has this really been missing all the time or could there be
differences in the mdstore protocol and/or firmware that cause this?

Diff below explicitly selects configuration in code.

Feedback? OK?

Index: ldomctl.c
===================================================================
RCS file: /cvs/src/usr.sbin/ldomctl/ldomctl.c,v
retrieving revision 1.31
diff -u -p -r1.31 ldomctl.c
--- ldomctl.c   28 Dec 2019 18:36:02 -0000      1.31
+++ ldomctl.c   30 Dec 2019 19:51:59 -0000
@@ -415,6 +415,7 @@ download(int argc, char **argv)
                ds_conn_handle(dc);
 
        mdstore_download(dc, argv[1]);
+       mdstore_select(dc, argv[1]);
 }
 
 void

Reply via email to