On Wed, Mar 04, 2020 at 07:48:28AM -0700, Theo de Raadt wrote:
> Job Snijders <j...@ntt.net> wrote:
>
> > I think we still need to support BIRD 1 for the foreseeable future, NIC.CZ
> > hasn’t communicated plans to deprecate BIRD1 and still supports it; and
> > BIRD1 still is widely deployed.
> >
> > I’m somewhat preferential to just generate all 3 BIRD flavors if -B is
> > given as command line option.
>
> output.c does the mkstemp dance above the output function, and it is
> table driven to generate one file with a function, per option.
>
> But imagine if the table was changed to do this:
>
> } outputs[] = {
> { FORMAT_OPENBGPD, "openbgpd", output_bgpd },
> { FORMAT_BIRD, "bird1v4", output_bird1v4 },
> { FORMAT_BIRD, "bird1v6", output_bird1v6 }
> { FORMAT_BIRD, "bird", output_bird2 }
> { FORMAT_CSV, "csv", output_csv },
> { FORMAT_JSON, "json", output_json },
> ...
>
> I'd like if someone wrote output_bird1v4, output_bird1v6, and output_bird2
> functions (or whatever the case may be), is that the way to do it?
I think that is a good way to solve this issue.
--
:wq Claudio
