On 2020/09/13 13:23, Klemens Nanni wrote: > On Sun, Sep 13, 2020 at 11:31:12AM +0100, Stuart Henderson wrote: > > On 2020/09/13 11:12, Stuart Henderson wrote: > > > This has been tried before, I forget what but there were problems > > > > from chat logs when I tried this before: > > > > 14:52 < sthen> if i kill the if_down, no crash, but the mac address doesn't > > get updated so i end up with the same one on em0, em1, trunk0 > Thanks for mentioning it, I'll look into whether I can fix this or we > have revert my commit to avoid breakage around MAC addresses. > > I'd expect such information to be present in CVS log or code (comments). >
It's not in CVS log because it was tested and didn't work so wasn't committed. I don't know if there's precedent for documenting everything somebody might try but fails in a code comment, feels like the tree would be littered with possibly outdated comments if that's done regularly?