On Tue, Nov 17, 2020 at 01:11:42PM +0100, Paul de Weerd wrote:
> On Tue, Nov 17, 2020 at 01:06:05AM +0100, Alexander Hall wrote:
...
> | The more I read and think about it, I feel the original error message is
> | actually correct in that there is no terminating ";" or "+", since the
> | required condition for it is not fullfilled...
>
> I still think the error is confusing for the user who, familiar with
> 'find -exec command {} arg \;', might assume the same would work for +.
> Now, your diff seems like a better approach, given your argument.
So this is it. Any other objections? OK?
/Alexander
Index: function.c
===================================================================
RCS file: /cvs/src/usr.bin/find/function.c,v
retrieving revision 1.49
diff -u -p -r1.49 function.c
--- function.c 9 Apr 2020 15:07:49 -0000 1.49
+++ function.c 21 Nov 2020 15:58:40 -0000
@@ -564,7 +564,7 @@ c_exec(char *unused, char ***argvp, int
*/
for (ap = argv = *argvp, brace = 0;; ++ap) {
if (!*ap)
- errx(1, "%s: no terminating \";\" or \"+\"",
+ errx(1, "%s: no terminating \";\" or \"{} +\"",
isok ? "-ok" : "-exec");
lastbrace = brace;
brace = 0;
