George Koehler <kern...@gmail.com> writes:
> On Mon, 30 Nov 2020 20:04:10 -0800
> Greg Steuck <gne...@openbsd.org> wrote:
>
>> Tested with a bunch of manual sysctl -w's.
>>
>> OK?
>
> I'm not sure about this diff. I'm more likely to do
> ddb{0}> set $radix = 0t2
> and less likely to do
> # sysctl ddb.radix=2
> but you enforce the range check (radix in 8..16) only in sysctl,
> not in ddb set.
>
> If I do ddb set a bad value, then sysctl refuses to show the value:
>
> # sysctl ddb.console=1
> ddb.console: 0 -> 1
> # sysctl ddb.trigger=1
> Stopped at ddb_sysctl+0x114: ori r0,r0,0x0
> ddb{0}> set $radix = 0t2
> ddb{0}> c
> ddb.trigger: 0 -> 1
> # sysctl ddb.radix
> sysctl: ddb.radix: Invalid argument
>
> This diff might be better than doing nothing? I'm not sure. --George
I'm game for changing the range of ddb.radix to [2..INT_MAX] if you
think that's better. I doubt it makes that much of a difference either
way.
Thanks
Greg
