No way for this diff.  This is the wrong way.  Surely there are ways
to disable compression negotion on specific sessions, but removing
the code from the kernel is the wrong knob.

Balder Oddson <ola...@gmail.com> wrote:

> Compression in PPP was great in the age of ISDN to increase speeds.
> The more common use cases, and trends concerning TLS1.3 advancements.
> 
> Having this enabled by default, and infrequently used could lead to
> unintended consequences around how the data is passed around.
> 
> 
> Index: GENERIC
> ===================================================================
> RCS file: /cvs/src/sys/conf/GENERIC,v
> retrieving revision 1.274
> diff -u -p -u -p -r1.274 GENERIC
> --- GENERIC   25 Feb 2021 01:19:35 -0000      1.274
> +++ GENERIC   25 Mar 2021 18:07:58 -0000
> @@ -50,8 +50,8 @@ option              TCP_SIGNATURE   # TCP MD5 Signatur
>  
>  option               INET6           # IPv6
>  option               IPSEC           # IPsec
> -option               PPP_BSDCOMP     # PPP BSD compression
> -option               PPP_DEFLATE
> +#option              PPP_BSDCOMP     # PPP BSD compression
> +#option              PPP_DEFLATE     # Disabled by default, TLS1.3 trends
>  option               PIPEX           # Ppp IP EXtension, for npppd
>  option               MROUTING        # Multicast router
>  option               MPLS            # Multi-Protocol Label Switching
> 

Reply via email to