On Thu, Jun 03, 2021 at 05:10:57PM +0200, Stefan Hagen wrote:
> Hi,
> 
> I'm using a Wacom CTL-490 to draw on virtual whiteboards in online
> meetings.

Hi,

I tried your patch and got rejections, though I was able to fix it.  I have
a Wacom Intuos.  I found that I could not write anything as good as with
the pressure having a higher threshold ie. the original driver.

That said I'm on 6.9, not on -current maybe there is differences with other
drivers that have an impact.

I used gimp to write with the wacom which is the utility I use to draw
when I do draw with the Intuos.


> Compared to linux/windows, it needs a lot of pressure to draw something
> on OpenBSD. This makes writing pretty hard.
> 
> In OpenBSD, a tip-pressure of >10 is required to activate button 0.
> 
> I'm not sure why this number was chosen. I assumed that it might be 
> because pressure reporting could be jittering.
> 
> I've set it to >0 for testing and I couldn't be happier. I tested it 
> with two pens and didn't experience any false-activation.
> 
> Would this patch okay with you?
> 
> uwacom author on cc.
> 
> Best Regards,
> Stefan

Best Regards,
-peter

> 
> Index: sys/dev/usb/uwacom.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/usb/uwacom.c,v
> retrieving revision 1.2
> diff -u -p -u -p -r1.2 uwacom.c
> --- sys/dev/usb/uwacom.c      23 Aug 2020 11:08:02 -0000      1.2
> +++ sys/dev/usb/uwacom.c      3 Jun 2021 14:40:37 -0000
> @@ -172,7 +172,7 @@ uwacom_intr(struct uhidev *addr, void *b
>                       buttons |= (1 << i);
>  
>       /* button 0 reporting is flaky, use tip pressure for it */
> -     if (pressure >10)
> +     if (pressure)
>               buttons |= 1;
>       else
>               buttons &= ~1;
> 

Reply via email to