> From: James Hastings <mooset...@gmail.com>
> Date: Sun, 27 Feb 2022 05:45:48 -0500 (EST)
>
> On Sun, Oct 10, 2021 at 11:42:31PM +0200, Mark Kettenis wrote:
> > > Date: Sat, 9 Oct 2021 22:27:52 +0200 (CEST)
> > > From: Mark Kettenis <mark.kette...@xs4all.nl>
> > >
> > > > Date: Sat, 9 Oct 2021 20:55:10 +0200 (CEST)
> > > > From: Mark Kettenis <mark.kette...@xs4all.nl>
> > > >
> > > > This time adding support for Sunrisepoint-H and Sunrisepoint-LP.
> > > > Because of all the failed attempts by Intel to get their 10nm process
> > > > under control, this may cover Intel Mobile CPUs marketed as 6th, 7th,
> > > > 8th, 9th and 10th generation. So if you have a Laptop that isn't at
> > > > least 5 years old, give this a try if pchgpio(4) doesn't attach. This
> > > > may fix all sorts of issues with keyboards, touchpads or
> > > > suspend/resume.
> > > >
> > > > ok?
> > >
> > > Updated diff that masks unhandled interrupts like we do in amdgpio(4).
> >
> > And another update to fix a typo in the pin groups for Sunrisepoint-LP.
>
> Updated again for correct pad size (8 bytes instead of 16).
This diff has been in snaps for more than a week and we have some
positive feedback.
So ok kettenis@
> Index: dev/acpi/pchgpio.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/acpi/pchgpio.c,v
> retrieving revision 1.10
> diff -u -p -r1.10 pchgpio.c
> --- dev/acpi/pchgpio.c 21 Dec 2021 20:53:46 -0000 1.10
> +++ dev/acpi/pchgpio.c 27 Feb 2022 09:29:17 -0000
> @@ -107,13 +107,76 @@ struct cfdriver pchgpio_cd = {
> };
>
> const char *pchgpio_hids[] = {
> + "INT344B",
> "INT3450",
> + "INT3451",
> + "INT345D",
> "INT34BB",
> "INT34C5",
> "INT34C6",
> NULL
> };
>
> +/* Sunrisepoint-LP */
> +
> +const struct pchgpio_group spt_lp_groups[] =
> +{
> + /* Community 0 */
> + { 0, 0, 0, 23, 0 }, /* GPP_A */
> + { 0, 1, 24, 47, 24 }, /* GPP_B */
> +
> + /* Community 1 */
> + { 1, 0, 48, 71, 48 }, /* GPP_C */
> + { 1, 1, 72, 95, 72 }, /* GPP_D */
> + { 1, 2, 96, 119, 96 }, /* GPP_E */
> +
> + /* Community 3 */
> + { 2, 0, 120, 143, 120 }, /* GPP_F */
> + { 2, 1, 144, 151, 144 }, /* GPP_G */
> +};
> +
> +const struct pchgpio_device spt_lp_device =
> +{
> + .pad_size = 8,
> + .gpi_is = 0x100,
> + .gpi_ie = 0x120,
> + .groups = spt_lp_groups,
> + .ngroups = nitems(spt_lp_groups),
> + .npins = 176,
> +};
> +
> +/* Sunrisepoint-H */
> +
> +const struct pchgpio_group spt_h_groups[] =
> +{
> + /* Community 0 */
> + { 0, 0, 0, 23, 0 }, /* GPP_A */
> + { 0, 1, 24, 47, 24 }, /* GPP_B */
> +
> + /* Community 1 */
> + { 1, 0, 48, 71, 48 }, /* GPP_C */
> + { 1, 1, 72, 95, 72 }, /* GPP_D */
> + { 1, 2, 96, 108, 96 }, /* GPP_E */
> + { 1, 3, 109, 132, 120 }, /* GPP_F */
> + { 1, 4, 133, 156, 144 }, /* GPP_G */
> + { 1, 5, 157, 180, 168 }, /* GPP_H */
> +
> + /* Community 3 */
> + { 2, 0, 181, 191, 192 }, /* GPP_I */
> +};
> +
> +const struct pchgpio_device spt_h_device =
> +{
> + .pad_size = 8,
> + .gpi_is = 0x100,
> + .gpi_ie = 0x120,
> + .groups = spt_h_groups,
> + .ngroups = nitems(spt_h_groups),
> + .npins = 224,
> +};
> +
> +/* Cannon Lake-H */
> +
> const struct pchgpio_group cnl_h_groups[] =
> {
> /* Community 0 */
> @@ -146,6 +209,8 @@ const struct pchgpio_device cnl_h_device
> .npins = 384,
> };
>
> +/* Cannon Lake-LP */
> +
> const struct pchgpio_group cnl_lp_groups[] =
> {
> /* Community 0 */
> @@ -173,6 +238,8 @@ const struct pchgpio_device cnl_lp_devic
> .npins = 320,
> };
>
> +/* Tiger Lake-LP */
> +
> const struct pchgpio_group tgl_lp_groups[] =
> {
> /* Community 0 */
> @@ -205,6 +272,8 @@ const struct pchgpio_device tgl_lp_devic
> .npins = 360,
> };
>
> +/* Tiger Lake-H */
> +
> const struct pchgpio_group tgl_h_groups[] =
> {
> /* Community 0 */
> @@ -242,7 +311,10 @@ const struct pchgpio_device tgl_h_device
> };
>
> struct pchgpio_match pchgpio_devices[] = {
> + { "INT344B", &spt_lp_device },
> { "INT3450", &cnl_h_device },
> + { "INT3451", &spt_h_device },
> + { "INT345D", &spt_h_device },
> { "INT34BB", &cnl_lp_device },
> { "INT34C5", &tgl_lp_device },
> { "INT34C6", &tgl_h_device },
> @@ -465,11 +537,38 @@ pchgpio_intr_establish(void *cookie, int
> }
>
> int
> +pchgpio_intr_handle(struct pchgpio_softc *sc, int group, int bit)
> +{
> + uint32_t enable;
> + int gpiobase, pin, handled = 0;
> + uint8_t bank, bar;
> +
> + bar = sc->sc_device->groups[group].bar;
> + bank = sc->sc_device->groups[group].bank;
> + gpiobase = sc->sc_device->groups[group].gpiobase;
> +
> + pin = gpiobase + bit;
> + if (sc->sc_pin_ih[pin].ih_func) {
> + sc->sc_pin_ih[pin].ih_func(sc->sc_pin_ih[pin].ih_arg);
> + handled = 1;
> + } else {
> + /* Mask unhandled interrupt */
> + enable = bus_space_read_4(sc->sc_memt[bar], sc->sc_memh[bar],
> + sc->sc_device->gpi_ie + bank * 4);
> + enable &= ~(1 << bit);
> + bus_space_write_4(sc->sc_memt[bar], sc->sc_memh[bar],
> + sc->sc_device->gpi_ie + bank * 4, enable);
> + }
> +
> + return handled;
> +}
> +
> +int
> pchgpio_intr(void *arg)
> {
> struct pchgpio_softc *sc = arg;
> uint32_t status, enable;
> - int gpiobase, group, bit, pin, handled = 0;
> + int group, bit, handled = 0;
> uint16_t base, limit;
> uint8_t bank, bar;
>
> @@ -478,7 +577,6 @@ pchgpio_intr(void *arg)
> bank = sc->sc_device->groups[group].bank;
> base = sc->sc_device->groups[group].base;
> limit = sc->sc_device->groups[group].limit;
> - gpiobase = sc->sc_device->groups[group].gpiobase;
>
> status = bus_space_read_4(sc->sc_memt[bar], sc->sc_memh[bar],
> sc->sc_device->gpi_is + bank * 4);
> @@ -491,10 +589,8 @@ pchgpio_intr(void *arg)
> continue;
>
> for (bit = 0; bit <= (limit - base); bit++) {
> - pin = gpiobase + bit;
> - if (status & (1 << bit) && sc->sc_pin_ih[pin].ih_func)
> -
> sc->sc_pin_ih[pin].ih_func(sc->sc_pin_ih[pin].ih_arg);
> - handled = 1;
> + if (status & (1 << bit))
> + handled |= pchgpio_intr_handle(sc, group, bit);
> }
> }
>
>
>
