On Tue, Mar 08, 2022 at 01:44:47PM +0000, Visa Hankala wrote:
> On Tue, Mar 08, 2022 at 08:04:36AM +0100, Anton Lindqvist wrote:
> > On Mon, Mar 07, 2022 at 07:36:35AM +0000, Visa Hankala wrote:
> > > I still think that checking TXFF and using the same code for both
> > > SBSA and true PL011 UARTs would be the best choice. This would avoid
> > > fragmenting the code and improve robustness by relying on functionality
> > > that is common to the different controller variants.
> > 
> > Fair enough, new diff.
> 
> Maybe the comments should omit the FIFO space description and just
> mention the lack of the level control register in the SBSA UART
> register interface.

I ended up tweaking the comments before committing. Thanks for all the
feedback.

Reply via email to