[
https://issues.apache.org/jira/browse/THRIFT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640039#action_12640039
]
Kevin Clark commented on THRIFT-165:
------------------------------------
Is there a reason the std namespace is imported into
compiler/cpp/src/generate/t_oop_generator.h?
Also, could you possibly update the fixtures data to reflect how the generated
code will look? I know we've had a regression or two recently because the
generated structs we were using in tests weren't the same as what's actually
being generated at this point. I'd like to keep the problem from getting worse,
if possible.
Generally looks good though.
> Add some additional reflection features to Ruby generated code
> --------------------------------------------------------------
>
> Key: THRIFT-165
> URL: https://issues.apache.org/jira/browse/THRIFT-165
> Project: Thrift
> Issue Type: New Feature
> Components: Compiler (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: thrift-165.patch
>
>
> Similar to THRIFT-139, it'd be nice if generated Ruby classes had constants
> for all their field names like MyStruct::FOO_FIELD. I don't think it's
> necessary to add getters and setters by field id, since it already has
> behavior like this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
