[
https://issues.apache.org/jira/browse/THRIFT-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640045#action_12640045
]
Kevin Clark commented on THRIFT-165:
------------------------------------
But upcase_string seems to use std:: explicitly for transform. Is it for the
string argument? Couldn't we just make it std::string and avoid the use
statement? Just seems like we don't need it, since the rest of the code
explicitly uses the namespace.
I agree, fixture data _should_ be regenerated, but isn't currently. I haven't
been given the ok by Microsoft to start contributing my own code back yet, so
I'm stuck asking other people to help in the meantime :\
> Add some additional reflection features to Ruby generated code
> --------------------------------------------------------------
>
> Key: THRIFT-165
> URL: https://issues.apache.org/jira/browse/THRIFT-165
> Project: Thrift
> Issue Type: New Feature
> Components: Compiler (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: thrift-165.patch
>
>
> Similar to THRIFT-139, it'd be nice if generated Ruby classes had constants
> for all their field names like MyStruct::FOO_FIELD. I don't think it's
> necessary to add getters and setters by field id, since it already has
> behavior like this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
