[ 
https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678746#action_12678746
 ] 

Esteve Fernandez commented on THRIFT-105:
-----------------------------------------

I think THRIFT-339 is similar to this one. Your patch looks a bit simpler (a 
good thing!), but the other one checks whether a tag is in a specified range. 
It needs an extra variable too, though. We could work together on merging both 
patches and fix negative tags once for all! :-)

> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
>                 Key: THRIFT-105
>                 URL: https://issues.apache.org/jira/browse/THRIFT-105
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python), Library (Python), Test Suite
>            Reporter: Alexander Shigin
>            Assignee: Alexander Shigin
>         Attachments: thrift-python-offset-v2.patch, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures. 
> The change allows to use fastbinary module for structures with negative tags.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to