[
https://issues.apache.org/jira/browse/THRIFT-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679218#action_12679218
]
Esteve Fernandez commented on THRIFT-105:
-----------------------------------------
Actually it's my fault for not linking both issues, THRIFT-105 is older than
THRIFT-339, and as such it should haven taken precedence over the latter.
Sadly, the patch for THRIFT-339 can't be split easily because both issues are
too closely related. Anyway, what are your thoughts between the two approaches?
I think the patch for THRIFT-339 is a bit more robust, as it checks boundaries,
but your patch is cleaner and less invasive.
Given that constructors have changed and the mega-patch for Twisted has been
committed, your patch no longer applies cleanly :-( I'll try to update it to
the current code base, so we can compare it against THRIFT-339 and agree on the
one that we like most.
> make a thrift_spec for a structures with negative tags
> ------------------------------------------------------
>
> Key: THRIFT-105
> URL: https://issues.apache.org/jira/browse/THRIFT-105
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Python), Library (Python), Test Suite
> Reporter: Alexander Shigin
> Assignee: Alexander Shigin
> Attachments: thrift-python-offset-v2.patch, thrift-python-offset.patch
>
>
> The patch introduces thrift_offset variable for a python thrift structures.
> The change allows to use fastbinary module for structures with negative tags.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
